So i got this sword that has alot of enchantments i use basically use it for everything so i put grinding enchantments and boss fights enchantments is there gonna be a limit to how many i can put?
You can put a maximum of 10 enchantments on a piece, thats the limit
But you can increase that limit by using an enchantment orb
Refer
this post for getting more info on that orb
and did i also make the right choice by putting in alot of basic enchantments.
Well there isnt a perfect right choice for enchanting
Its better to create differently enchanted same items for different purposes and one good mixed enchanted item
Like you may need a different sword for boss pvp, a different for pvping with players, a different for when you are just farming
Or you may just get it all in one, its really your choice to make
You could also watch kill messages and inventories of players to get an idea on which enchantments are better
There are plenty of posts on this topic in this forum
Heres one of them
https://jartexnetwork.com/threads/a-question-for-boss-world.311670/#post-891846